Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Support large page sizes on AArch64 #1547

Merged
merged 1 commit into from May 4, 2024

Conversation

tavianator
Copy link
Collaborator

Fixes #1085.

@tmccombs
Copy link
Collaborator

tmccombs commented May 4, 2024

Will this break any aarch64 systems? Or will it just use more memory?

@tavianator
Copy link
Collaborator Author

I don't think it will break any systems, but I'll test it on mine just to be sure. I don't have one with large pages though so I can't even validate the fix

@tmccombs tmccombs merged commit cd96ca0 into sharkdp:master May 4, 2024
17 checks passed
@mathomp4
Copy link

mathomp4 commented May 4, 2024

I don't think it will break any systems, but I'll test it on mine just to be sure. I don't have one with large pages though so I can't even validate the fix

Well, once it's in a release, I can test it.

Or I guess I can do the cargo route! How would someone who's never used cargo outside of a tutorial get and test this? 😄

@tavianator
Copy link
Collaborator Author

I think just

$ JEMALLOC_SYS_WITH_LG_PAGE=16 cargo install fd-find

should work

@tmccombs
Copy link
Collaborator

tmccombs commented May 4, 2024

I'll try to put together a release tonight

@tavianator tavianator deleted the jemalloc-aarch64 branch May 5, 2024 18:37
@mathomp4
Copy link

mathomp4 commented May 6, 2024

Sadly, this did not seem to fix it on my NVIDIA GraceGrace node. Let me try a cargo build...

ETA: Well, I grabbed rustup and:

JEMALLOC_SYS_WITH_LG_PAGE=16 cargo install fd-find

did work. I am ... baffled.

@tavianator
Copy link
Collaborator Author

@mathomp4 Oh, that's my mistake, I didn't realize the cross build uses docker. I made #1549 which should fix it for real.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary releases of fd crash on Asahi Linux because of jemalloc using 8kb page sizes
3 participants