Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fd is now officially in Debian #345

Merged
merged 2 commits into from
Oct 14, 2018
Merged

fd is now officially in Debian #345

merged 2 commits into from
Oct 14, 2018

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Oct 14, 2018

Work by @paride and the debian rust team!

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great news! Thank you very much for your work (and everyone else that has helped)!

README.md Outdated
@@ -132,6 +132,15 @@ Download the latest `.deb` package from the [release page](https://github.com/sh
sudo dpkg -i fd_7.0.0_amd64.deb # adapt version number and architecture
```

### On Ubuntu
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Debian? :-)

```
$ sudo apt-get install fd-find
```
The binary is called `fdfind` as the binary name `fd` is already used by another package.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should recommend alias fd=fdfind here to make the documentation (README and man page) consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably.
we are also discussing about other options like install fd in a specific path and recommending to update PATH

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll add the note about the alias for now. If there is a better solution in the future, I'm happy to change the instructions.

@sharkdp sharkdp merged commit d81cf34 into sharkdp:master Oct 14, 2018
@sylvestre
Copy link
Contributor Author

by the way @sharkdp how would you fill about renaming fd to fdfind?
it would help on debian :)

@sharkdp
Copy link
Owner

sharkdp commented Oct 14, 2018

by the way @sharkdp how would you fill about renaming fd to fdfind?
it would help on debian :)

I would rather not. I don't really like fdfind/fd-find because it duplicates the word "find" and its abbreviation.

We have had a similar discussion in this ticket. However, this discussion is now over a year old and I believe that the name "fd" has now made it into a few online discussions and blog posts. "fd" is also available as a package named "fd" (with a binary named "fd") in a lot of different distributions and package managers. See this ticket for a similar discussion with @paride. I would therefore like to avoid any renaming.

See also my comment in this discussion:

I knew that there was a price to pay (name clashes, harder to find) when naming this fd, but I wanted to have something short like rg, ag, ls, etc. Of course, I could have asked all users to set an alias fd, but somehow that doesn't seem very user-friendly to me.

@sharkdp
Copy link
Owner

sharkdp commented Oct 14, 2018

Also, sorry for the trouble that this causes with Debian packaging. I really appreciate your effort!

Does Ubuntu have a different policy?

@paride
Copy link

paride commented Oct 15, 2018

@sharkdp I'm not sure, but Ubuntu is likely to inherit the Debian package at some point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants