Highlight matches #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
force-pushed
the
highlight_match
branch
from
4c57a29
to
8b175c1
Compare
|
I'm going to close this, as I don't really like how (a) the output looks like and (b) the code looks like 😄 |
|
This patch is also missing the ability to highlight multiple matched segments (eg: matching "a" in "foo bar baz"). If you don't like how the underline looks, another option would be to change the background colour -- that can also be done independently of the foreground colour... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working prototype with underlining to highlight the matched part of the file path.
TODO:
fd -p, so far.I'm not sure that I like this better than the non-highlighted version.