Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexyl: add display offset option #72

Merged
merged 1 commit into from
Oct 7, 2019
Merged

hexyl: add display offset option #72

merged 1 commit into from
Oct 7, 2019

Conversation

tommilligan
Copy link
Contributor

See #57 for feature description.

Adds the -o/--display-offset flag to the hexyl binary, and a Printer.display_offset field to lib.rs.

Featuring:

  • back-compatible API changes
  • xxd compatible -o flag
  • a test!

sharkdp
sharkdp approved these changes Oct 7, 2019
View reviewed changes
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you very much.

@sharkdp sharkdp merged commit d640537 into sharkdp:master Oct 7, 2019
@sharkdp sharkdp mentioned this pull request Oct 7, 2019
Closed
@ErichDonGubler ErichDonGubler mentioned this pull request Nov 16, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkdp sharkdp sharkdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tommilligan @sharkdp