-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thou
unit
#195
Add thou
unit
#195
Conversation
src/Insect/Parser.purs
Outdated
@@ -261,6 +261,7 @@ imperialUnitDict = Dictionary | |||
, Q.inch ==> ["inches", "inch", "in"] | |||
, Q.yard ==> ["yards", "yard", "yd"] | |||
, Q.foot ==> ["feet", "foot", "ft"] | |||
, Q.thou ==> ["thou", "mils", "mil"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the two alternative versions (mils
and mil
)? I have personally never heard of them and I think they could be confused with mile
/miles
. Admittedly, I have never heard of thou
either 😄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I come across mil
much more often than thou
. But I don't mind just remembering to use thou
. Will update.
(Yes they're silly units, but unfortunately still in use!)
I have published a new version of purescript-quantities: https://pursuit.purescript.org/packages/purescript-quantities/8.3.0 |
(Also known as `mil` or `mils` but not added as aliases to avoid confusion with `mile`). These come up a lot in PCB design (e.g. track widths are measured in thou) https://en.wikipedia.org/wiki/Thousandth_of_an_inch
Sorry to bump this old issue, but it seems that I can't really seem to find the reason why... maybe the commit was reverted/pruned? |
I think the change is gone as the branch was force-pushed. I'm okay with adding them 👍. Didn't know they would be that popular. |
You'll add them? Great, thanks! Yeah, as previously mentioned, |
Well, if you could send a PR, that would be great. Changes should be similar to the ones in this PR. Updating , Q.thou ==> ["thou"] needs to be modified to also include |
As discussed in this issue: sharkdp#195
Just wanted to know if there's any issues with the submitted PR? |
As discussed in this issue: #195
These come up a lot in PCB design (e.g. track widths are measured in thou)
https://en.wikipedia.org/wiki/Thousandth_of_an_inch
Based on sharkdp/purescript-quantities#38 to add
thou
to purescript-quantities (so I will add a change to package.json to up the version number if that gets merged).