Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "mil" and "mils" to Parser #234

Merged
merged 3 commits into from
Sep 20, 2020
Merged

Conversation

tomioe
Copy link
Contributor

@tomioe tomioe commented Aug 3, 2020

As discussed in this issue: #195

As discussed in this issue: sharkdp#195
@sharkdp
Copy link
Owner

sharkdp commented Sep 1, 2020

Thank you for your contribution!

Could you please also update the documentation accordingly (see analogous changes in the thou pull request).

@tomioe
Copy link
Contributor Author

tomioe commented Sep 8, 2020

Done deal! Sorry about the delay, I missed your comment.

@tomioe
Copy link
Contributor Author

tomioe commented Sep 14, 2020

Done deal! Sorry about the delay, I missed your comment.

Nope, I messed up the PR (pushed to my own master branch instead of the PR branch...).
Should be going through now.

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sharkdp sharkdp merged commit 058ae8b into sharkdp:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants