Skip to content

Commit

Permalink
Merge pull request #570 from orende/feature/more-tooltips
Browse files Browse the repository at this point in the history
Add additional explanatory tooltips
  • Loading branch information
sharkwouter committed Jun 22, 2023
2 parents 8c9d4ef + 316b93b commit b0c64e8
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Update Spanish translation (thanks to manurtinez)
- Capitalize first letter of the "play/download/..." button (thanks to lmeunier)
- Update Traditional Chinese translation (thanks to s8321414)
- Added additional tooltips to buttons, labels, menu items and radio buttons (thanks to orende)

**1.2.2**
- Fix progress bar not showing up for downloads
Expand Down
2 changes: 2 additions & 0 deletions data/ui/application.ui
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
<property name="valign">center</property>
<property name="use_popover">False</property>
<property name="popover">menu</property>
<property name="tooltip_text" translatable="yes" context="menu" comments="Tooltip for header menu button">Options menu</property>
<child>
<object class="GtkImage">
<property name="visible">True</property>
Expand All @@ -147,6 +148,7 @@
<property name="primary_icon_name">edit-find-symbolic</property>
<property name="primary_icon_activatable">False</property>
<property name="primary_icon_sensitive">False</property>
<property name="tooltip_text" translatable="yes" context="search" comments="Tooltip for search field">Search games list</property>
<signal name="search-changed" handler="filter_library" swapped="no"/>
</object>
<packing>
Expand Down
19 changes: 19 additions & 0 deletions data/ui/properties.ui
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
<property name="label" translatable="yes">Regedit</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Open Regedit for this game</property>
<property name="receives-default">True</property>
<signal name="clicked" handler="on_button_properties_regedit_clicked" swapped="no"/>
</object>
Expand All @@ -61,6 +62,7 @@
<property name="label" translatable="yes">Winecfg</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Open Winecfg for this game</property>
<property name="receives-default">True</property>
<signal name="clicked" handler="on_button_properties_winecfg_clicked" swapped="no"/>
</object>
Expand All @@ -74,6 +76,7 @@
<property name="label" translatable="yes">Open files</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Open game install folder</property>
<property name="receives-default">True</property>
<signal name="clicked" handler="on_button_properties_open_files_clicked" swapped="no"/>
</object>
Expand All @@ -87,6 +90,7 @@
<property name="label" translatable="yes">Winetricks</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Open Winetricks for this game</property>
<property name="receives-default">True</property>
<signal name="clicked" handler="on_button_properties_winetricks_clicked" swapped="no"/>
</object>
Expand All @@ -101,6 +105,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Check for updates:</property>
<property name="tooltip-text" translatable="yes">Check for game updates in the background</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -112,6 +117,7 @@
<object class="GtkSwitch" id="switch_properties_check_for_updates">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Check for game updates in the background</property>
<property name="halign">start</property>
<property name="valign">center</property>
</object>
Expand All @@ -126,6 +132,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Show FPS in game:</property>
<property name="tooltip-text" translatable="yes">Show an FPS (frames per second) counter overlaid in the game</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -137,6 +144,7 @@
<object class="GtkSwitch" id="switch_properties_show_fps">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Show an FPS (frames per second) counter overlaid in the game</property>
<property name="halign">start</property>
<property name="valign">center</property>
</object>
Expand All @@ -151,6 +159,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Hide game:</property>
<property name="tooltip-text" translatable="yes">Hides the game from the games list</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -162,6 +171,7 @@
<object class="GtkSwitch" id="switch_properties_hide_game">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Hides the game from the games list</property>
<property name="halign">start</property>
<property name="valign">center</property>
</object>
Expand All @@ -176,6 +186,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Use GameMode:</property>
<property name="tooltip-text" translatable="yes">Enables GameMode, a daemon and library combo that allows games to request a set of optimisations be temporarily applied to the host OS</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -187,6 +198,7 @@
<object class="GtkSwitch" id="switch_properties_use_gamemode">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Enables GameMode, a daemon and library combo that allows games to request a set of optimisations be temporarily applied to the host OS</property>
<property name="halign">start</property>
<property name="valign">center</property>
</object>
Expand All @@ -201,6 +213,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Use MangoHud:</property>
<property name="tooltip-text" translatable="yes">Enables MangoHud, an overlay for performance monitoring and benchmarking using Vulcan and OpenGL</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -212,6 +225,7 @@
<object class="GtkSwitch" id="switch_properties_use_mangohud">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Enables MangoHud, an overlay for performance monitoring and benchmarking using Vulcan and OpenGL</property>
<property name="halign">start</property>
<property name="valign">center</property>
</object>
Expand All @@ -226,6 +240,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Variable flags:</property>
<property name="tooltip-text" translatable="yes">Added in front of the command used to launch the game</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -251,6 +266,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Command flags:</property>
<property name="tooltip-text" translatable="yes">Added at the end of the command used to launch the game</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -275,6 +291,7 @@
<property name="label" translatable="yes">Reset wine executable</property>
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="tooltip-text" translatable="yes">Reset the wine executable for this game</property>
<property name="receives-default">True</property>
<signal name="clicked" handler="on_button_properties_reset_clicked" swapped="no"/>
</object>
Expand All @@ -289,6 +306,7 @@
<property name="can-focus">False</property>
<property name="halign">end</property>
<property name="label" translatable="yes">Wine executable:</property>
<property name="tooltip-text" translatable="yes">Set Wine executable</property>
<property name="justify">fill</property>
</object>
<packing>
Expand All @@ -301,6 +319,7 @@
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="title" translatable="yes"/>
<property name="tooltip-text" translatable="yes">Set Wine executable</property>
</object>
<packing>
<property name="left-attach">1</property>
Expand Down
7 changes: 6 additions & 1 deletion minigalaxy/ui/gametile.py
Original file line number Diff line number Diff line change
Expand Up @@ -502,12 +502,14 @@ def reload_state(self):

def __state_downloadable(self):
self.button.set_label(_("Download"))
self.button.set_tooltip_text(_("Download and install the game"))
self.button.set_sensitive(True)
self.image.set_sensitive(False)

# The user must have the possibilty to access
# The user must have the possibility to access
# to the store button even if the game is not installed
self.menu_button.show()
self.menu_button.set_tooltip_text(_("Show game options menu"))
self.menu_button_update.hide()
self.menu_button_dlc.hide()
self.menu_button_uninstall.hide()
Expand All @@ -518,6 +520,7 @@ def __state_downloadable(self):

def __state_installable(self):
self.button.set_label(_("Install"))
self.button.set_tooltip_text(_("Install the game"))
self.button.set_sensitive(True)
self.image.set_sensitive(False)
self.menu_button.hide()
Expand Down Expand Up @@ -558,10 +561,12 @@ def __state_installing(self):

def __state_installed(self):
self.button.set_label(_("Play"))
self.button.set_tooltip_text(_("Launch the game"))
self.button.get_style_context().add_class("suggested-action")
self.menu_button.get_style_context().add_class("suggested-action")
self.button.set_sensitive(True)
self.image.set_sensitive(True)
self.menu_button.set_tooltip_text(_("Show game options menu"))
self.menu_button.show()
self.menu_button_uninstall.show()
self.button_cancel.hide()
Expand Down
7 changes: 6 additions & 1 deletion minigalaxy/ui/gametilelist.py
Original file line number Diff line number Diff line change
Expand Up @@ -517,12 +517,14 @@ def reload_state(self):

def __state_downloadable(self):
self.button.set_label(_("download"))
self.button.set_tooltip_text(_("Download and install the game"))
self.button.set_sensitive(True)
self.image.set_sensitive(False)

# The user must have the possibilty to access
# The user must have the possibility to access
# to the store button even if the game is not installed
self.menu_button.show()
self.menu_button.set_tooltip_text(_("Show game options menu"))
self.menu_button_update.hide()
self.menu_button_dlc.hide()
self.menu_button_uninstall.hide()
Expand All @@ -536,6 +538,7 @@ def __state_downloadable(self):

def __state_installable(self):
self.button.set_label(_("install"))
self.button.set_tooltip_text(_("Install the game"))
self.button.set_sensitive(True)
self.image.set_sensitive(False)
self.menu_button.hide()
Expand Down Expand Up @@ -583,10 +586,12 @@ def __state_installing(self):

def __state_installed(self):
self.button.set_label(_("play"))
self.button.set_tooltip_text(_("Launch the game"))
self.button.get_style_context().add_class("suggested-action")
self.button.set_sensitive(True)
self.image.set_sensitive(True)
self.menu_button.show()
self.menu_button.set_tooltip_text(_("Show game options menu"))
self.menu_button_uninstall.show()
self.button_cancel.hide()
self.game.set_install_dir(self.config.install_dir)
Expand Down

0 comments on commit b0c64e8

Please sign in to comment.