Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check disk space in the nearest existing directory #577

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Check disk space in the nearest existing directory #577

merged 1 commit into from
Jul 30, 2023

Conversation

Unrud
Copy link
Contributor

@Unrud Unrud commented Jul 27, 2023

Description

Check the available disk space in the nearest existing directory, instead of the parent directory. Fixes #448

Checklist

  • CHANGELOG.md was updated (format: - Change made (thanks to github_username))

sharkwouter
sharkwouter requested changes Jul 28, 2023
View reviewed changes
Copy link
Owner

@sharkwouter sharkwouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for figuring this one out and suggesting a fix, that's really appreciated! I did leave one comment. Thanks for contributing.

minigalaxy/installer.py Outdated Show resolved Hide resolved
@Unrud Unrud force-pushed the fix/check-disk-space branch 2 times, most recently from 8aab409 to e6d5797 Compare July 29, 2023 16:24
@Unrud Unrud changed the title Check disk space in the nearest existing directory WIP: Check disk space in the nearest existing directory Jul 29, 2023
@Unrud Unrud changed the title WIP: Check disk space in the nearest existing directory Check disk space in the nearest existing directory Jul 29, 2023
@Unrud Unrud requested a review from sharkwouter July 29, 2023 17:06
@Unrud
Copy link
Contributor Author

Unrud commented Jul 29, 2023

I approached the issue from another angle and replaced the call of check_diskspace(..., config.install_dir) instead.

@sharkwouter sharkwouter merged commit 6eebdf1 into sharkwouter:master Jul 30, 2023
2 checks passed
@sharkwouter
Copy link
Owner

Thanks!

@sharkwouter sharkwouter added this to the 2.0.0 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkwouter sharkwouter Awaiting requested review from sharkwouter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Download error: Not enough disk space to install game
2 participants
@Unrud @sharkwouter