Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC22: Add Chart Settings Dashboard #63

Merged
merged 2 commits into from
Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@
"react/jsx-filename-extension": 0,
"no-plusplus": 0,
"no-param-reassign": ["error", { "props": false }],
"prefer-destructuring": ["error", { "object": true, "array": false }]
"prefer-destructuring": ["error", { "object": true, "array": false }],
"jsx-a11y/label-has-associated-control": [
"error",
{
"required": {
"some": ["nesting", "id"]
}
}
],
"jsx-a11y/label-has-for": [
"error",
{
"required": {
"some": ["nesting", "id"]
}
}
]
}
}
1 change: 0 additions & 1 deletion config/demo.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"MARGIN_OF_GRID_VIEW": [10, 10],
"DATA_RESOURCE_URL": "../config/wines.csv",
"DATA_FORMAT": "csv",
"HIDE_BORDER": true,
"THEME_COLOR": "#007bff",
"VISUALIZATION_VIEW_CONFIGURATION": [
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"crossfilter2": "^1.5.4",
"d3": "^5.16.0",
"jquery": "^3.5.1",
"lodash": "^4.17.20",
"lodash": "^4.17.21",
"mdbreact": "^5.2.0",
"parcel-bundler": "^1.12.4",
"popper.js": "^1.16.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function VisGridItem(props) {
toggleFullScreen={props.toggleFullScreen}
fullScreened={props.fullScreened}
hover={hover}
setHover={setHover}
filters={filters}
filterRemove={removeFiltersHandler}
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import React from 'react';
import React, { useState } from 'react';
import Button from 'react-bootstrap/Button';

import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faCompressArrowsAlt, faExpandArrowsAlt } from '@fortawesome/free-solid-svg-icons';
import PropTypes from 'prop-types';
import VisSettings from '../../../../VisSettings/VisSettings';

// css class
import './VisGridItemControl.css';

function VisGridItemControl(props) {
const [show, setShow] = useState(false);
let btnFilterRemove;
if (props.filters.length > 0 && props.filters.find((f) => f.id === props.id)) {
btnFilterRemove = (
Expand All @@ -25,18 +27,10 @@ function VisGridItemControl(props) {
}
return (
<div>
{props.hover && (
{(props.hover || show) && (
<div className="vis-grid-item-control">
{btnFilterRemove}

<Button
style={{
background: 'none',
border: 'none',
}}
>
<FontAwesomeIcon icon="info-circle" />
</Button>
<VisSettings id={props.id} show={show} setShow={setShow} setHover={props.setHover} />
<Button
style={{
background: 'none',
Expand All @@ -61,4 +55,5 @@ VisGridItemControl.propTypes = {
filterRemove: PropTypes.func.isRequired,
fullScreened: PropTypes.bool.isRequired,
toggleFullScreen: PropTypes.func.isRequired,
setHover: PropTypes.func.isRequired,
};
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ function VisGridItemHeader(props) {
fullScreened={props.fullScreened}
toggleFullScreen={props.toggleFullScreen}
hover={props.hover}
setHover={props.setHover}
filters={props.filters}
filterRemove={props.filterRemove}
/>
Expand All @@ -45,4 +46,5 @@ VisGridItemHeader.propTypes = {
filterRemove: PropTypes.func.isRequired,
fullScreened: PropTypes.bool.isRequired,
toggleFullScreen: PropTypes.func.isRequired,
setHover: PropTypes.func.isRequired,
};
21 changes: 17 additions & 4 deletions source/components/Layout/VisGridView/VisGridView.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ function VisGridView({ fullVisScreenHandler, fullScreened }) {
&& margins[1] === appLayout.margins[1]
) return;
const gridLayoutWidth = cols * grid[0] + (cols + 1) * margins[0];

const updatedLayout = getLayoutConfig(visConfig, cols);

setAppLayout({
Expand All @@ -60,7 +59,6 @@ function VisGridView({ fullVisScreenHandler, fullScreened }) {
const debouncedUpdateViewSize = debounce(updateViewSize, 100);

useEffect(() => {
// console.log('kaak');
// if (!appLayout.currentCols) updateViewSize();
updateViewSize();
window.addEventListener('resize', debouncedUpdateViewSize);
Expand All @@ -69,6 +67,21 @@ function VisGridView({ fullVisScreenHandler, fullScreened }) {
};
}, [appLayout.currentCols, config.UNIT_OF_GRID_VIEW, config.UNIT_OF_GRID_VIEW]);

useEffect(() => {
const rect = self.current.getBoundingClientRect();
const cols = parseInt((rect.width - margins[0]) / (grid[0] + margins[0]), 10);
const gridLayoutWidth = cols * grid[0] + (cols + 1) * margins[0];
const updatedLayout = getLayoutConfig(visConfig, cols);

setAppLayout({
width: gridLayoutWidth,
currentCols: cols,
layout: updatedLayout.layout,
margins,
grid,
});
}, [visConfig]);

return (
<div className="vis-grid-view" ref={self}>
{appLayout.layout.length > 0 && (
Expand All @@ -80,7 +93,7 @@ function VisGridView({ fullVisScreenHandler, fullScreened }) {
layout={appLayout.layout}
draggableHandle={draggableHandle}
>
{appLayout.layout.map((item, index) => (
{appLayout.layout.map((item) => (
<div
key={item.i}
style={{
Expand All @@ -91,7 +104,7 @@ function VisGridView({ fullVisScreenHandler, fullScreened }) {
>
<VisGridItem
layout={appLayout}
operation={visConfig[index]}
operation={visConfig.find((vis) => vis.id === item.i)}
toggleFullScreen={fullVisScreenHandler}
fullScreened={fullScreened}
/>
Expand Down
2 changes: 2 additions & 0 deletions source/components/Settings/containers/ColumnInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ ColumnInput.propTypes = {
value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
setValue: PropTypes.func.isRequired,
type: PropTypes.string,
disabled: PropTypes.bool,
};

ColumnInput.defaultProps = {
type: 'text',
disabled: false,
};
50 changes: 50 additions & 0 deletions source/components/VisSettings/VisSettings.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
.visSettings-row {
display: flex;
}

.visSettings-label {
font-family: "Rubik", sans-serif;
font-style: normal;
font-weight: 600;
font-size: 24px;
line-height: 29px;

display: inline-block;
margin-bottom: 5px;
color: #152536;
}

.visSettings-input {
/* /Gray / White */

background: #ffffff;
/* Stroke/Input */

border: 1px solid #ced4da;
border-radius: 4px;

font-family: "Rubik", sans-serif;
height: 38px;
padding: 10px 5px;
font-style: normal;
font-weight: 400;
font-size: 16px;
line-height: 21px;
/* identical to box height, or 131% */

/* Secondary/Light Color */

color: #abb5be;
}

.visSettings-input:focus {
color: #152536;
}

.icon:hover {
cursor: pointer;
}

.icon {
margin: 0px 5px;
}
Loading