Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Newtonsoft.Json reference from SharpArch.Domain #232

Closed
cd21h opened this issue Dec 28, 2020 · 0 comments
Closed

Remove Newtonsoft.Json reference from SharpArch.Domain #232

cd21h opened this issue Dec 28, 2020 · 0 comments
Labels
breaking-change Breaking changes
Projects
Sharp-Architecture
Milestone
7.0.0

Comments

@cd21h
Copy link

cd21h commented Dec 28, 2020

There are two reasons for removing this reference:

  • .NET now has it's own JSON serializer - System.Text.Json.
  • Using domain entities as public contracts is not recommended.
@cd21h cd21h added the breaking-change Breaking changes label Dec 28, 2020
@cd21h cd21h added this to the 7.0 milestone Dec 28, 2020
@cd21h cd21h added this to Todo in Sharp-Architecture via automation Dec 28, 2020
cd21h added a commit that referenced this issue Dec 28, 2020
@cd21h
BREAKING: Entity/Repository cleanup, see #231
b713a16 
* Rename IEntityWithTypedId<TId> to IEntity<TId>
* Remove Entity<int>, replace EnitytWithTypedId<TId> with Entity<TId>
* Remove Reference to Newtonsoft.Json from SharpArch.Domain see #232
@cd21h cd21h moved this from Todo to In Progress in Sharp-Architecture Dec 28, 2020
@cd21h cd21h mentioned this issue Jan 10, 2021
Merged
cd21h added a commit that referenced this issue Jan 10, 2021
@cd21h
Simplify Entity and Repository structure (#233)
d607e81 
* BREAKING: Entity/Repository cleanup, see #231

* Rename IEntityWithTypedId<TId> to IEntity<TId>
* Remove Entity<int>, replace EnitytWithTypedId<TId> with Entity<TId>
* Remove Reference to Newtonsoft.Json from SharpArch.Domain see #232
@cd21h cd21h moved this from In Progress to Done in Sharp-Architecture Jan 10, 2021
@cd21h cd21h closed this as completed Jan 10, 2021
cd21h added a commit that referenced this issue May 31, 2021
@cd21h
Simplify Entity and Repository structure (#233)
f5cf9d9 
* BREAKING: Entity/Repository cleanup, see #231

* Rename IEntityWithTypedId<TId> to IEntity<TId>
* Remove Entity<int>, replace EnitytWithTypedId<TId> with Entity<TId>
* Remove Reference to Newtonsoft.Json from SharpArch.Domain see #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Breaking changes
Projects
No open projects
Sharp-Architecture
  
Done
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@cd21h