Add LinearSpeedChange #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add base class for iterative changes - Add example #57 (non-breaking)
|
@Vouzamo Can you have a look into this Pull Request (and review it)? I took this iterative approach originally from your source base and saw it in different other places. |
tthiery
commented
Sep 2, 2020
| _logger = logger; | ||
| } | ||
|
|
||
| public async Task ExecuteAsync(TachoMotor motor, sbyte startSpeed, sbyte endSpeed, int steps, int milliseconds, CancellationTokenSource cts = default) |
There was a problem hiding this comment.
I am not so sure about this API interface. Should this routine auto-calculate the steps (to e.g. bring each change of motor speed in a sub (e.g.) 200ms interval?
- Waiting Time is adjusted to command execution time (IO) #57 non-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57 (non-breaking)