Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allow_if_user to replace allow_if. #42

Merged
merged 3 commits into from
Mar 4, 2015
Merged

Added allow_if_user to replace allow_if. #42

merged 3 commits into from
Mar 4, 2015

Conversation

jacobian
Copy link
Contributor

@jacobian jacobian commented Feb 9, 2015

This allows passing the entire user resource, which means you can switch on
interesting things like user['two_factor_enabled'].

My Ruby-fu is semi-weak, so please LMK if this is the right way to be doing this.

This allows passing the entire user resource, which means you can switch on
interesting things like `user['two_factor_enabled']`.
@wuputah
Copy link
Contributor

wuputah commented Feb 10, 2015

I'd like to maintain backwards compatibility (and tests) for allow_if. If you're not comfortable drafting that up, I could take a shot.

Please also update the README. 😁

@jacobian
Copy link
Contributor Author

@wuputah I believe I did maintain compatibility with allow_if -- I didn't remove any tests, at least. Do you mean the deprecation warning? So just keep both allow_if and allow_if_user to peacefully co-exist?

D'oh on the README, I should know better. On it.

@jacobian
Copy link
Contributor Author

@wuputah this more like what you had in mind?

@wuputah
Copy link
Contributor

wuputah commented Feb 14, 2015

Yes! Though it doesn't seem like you're deprecating allow_if now, though that's a design decision (to have both options or only one).

wuputah added a commit that referenced this pull request Mar 4, 2015
Added allow_if_user to replace allow_if.
@wuputah wuputah merged commit fe514da into master Mar 4, 2015
@wuputah wuputah deleted the allow_if_user branch March 4, 2015 03:23
@danp
Copy link
Contributor

danp commented Mar 4, 2015

👏

@danp danp mentioned this pull request Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants