Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure suite #32

Merged
merged 31 commits into from
Aug 21, 2024
Merged

Restructure suite #32

merged 31 commits into from
Aug 21, 2024

Conversation

shashwatahalder01
Copy link
Owner

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

  • Closes #

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

mrabbani and others added 6 commits August 13, 2024 11:21
@mrabbani
Refactor TDD to replace setUp and tearDown methods with set_up and te…
2a015fc 
…ar_down. (getdokan#2335)

* Update tdd  docs

* refactor: setUp and tearDown methods

* Update docblocks
@shashwatahalder01
Add Shipping status API tests (getdokan#2337)
76c9cb1 
* add shipping status tests

* Update shipping status tests

* Update shipping status payload
@shashwatahalder01
Add tests (tax, shipping, payment, catalog mode, reverse withdrawal ,…
b607880 
… wholesale customer) (test automation) (getdokan#2338)

* Update feature map

* Add tax, shipping, payment tests and refactor some methods, locators

* Fix order again test

* Add updateDokanSettings method and helper methods

* Add product catalog mode tests and dbuitls methos

* Add reverse withdrawal tests

* Update package and fix locator issue

* Fix a locator and lint issue

* Refactor taxpage and skipped failed test

* Refactor admin test

* Revert a locator change

* Add Fixtures

* Resove pr reviews

* Fix wholesale customer tests

* Fix lint issue and a locator

* Fix prettier issue

* Fix booking tests

* Refactor some method names

* Add tslib package

* Refactor apiutils methods

* Refactor shortcode method tests

* Update some methos, locators & data

* Update lint issues

* Add a  test

* Refactor several methods

* Refactor setup tests

* Fix DB query issue

* Fix serializeData issue

* Update plugin name

* Fix auth issue

* Fix serialize issue

* Update dbutils methos for query contains single quotes and  HTML entities

* Fix auth issue

* Fix hover issue & update query parameter

* Add local site setup tests & update some metods

* Add remove previously cloned repo

* Resolve some todos and add a test

* Sync e2e and api project

* Fix fail tests

* Fix rfq afterall issue

* Remove unused code

* Update suite config, dbdata

* Add grep& grep invert forboth test suite

* Update package & script commands

* Add a php value to htaccess

* Disable showing PHP error

* Add subscription product methods in dbUtils & update config

* Remove .only

* Update project config

* Fix a fail test

* Update test tag

* Update yml

* Remove .only

* Fix couple of flaky tests

* Fix lint issues

* Fix type issues
@shashwatahalder01
Add lint rule and fix lint issues
400df84
@shashwatahalder01
Update playwright methods
d0ce0ee
@shashwatahalder01
Merge branch 'develop' into develop_rk
7288f85
@shashwatahalder01 shashwatahalder01 self-assigned this Aug 18, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

Tests Summary

Commit SHA: 900d696

Test 🧪Total 📊Passed ✅Failed 🚨Flaky 🚧Skipped ⏭️Duration ⏰Coverage 🏁
API Tests34732900181m 9s78.44%
E2E Tests725632078610m 52s74.83%
Test Environment Details:
  • WordPress Version: 6.6.1
  • PHP Version: 7.4.33
  • MySql Version: 11.4.3
  • Debug Mode: true
  • Theme: Storefront v4.6.0
  • Plugins:
    • Basic-Auth v0.1
    • dokan v3.11.5
    • dokan-pro v3.11.4
    • woocommerce v9.1.4
    • woocommerce-bookings v2.1.5
    • woocommerce-product-addons v7.0.1
    • woocommerce-simple-auctions v3.0.1
    • woocommerce-subscriptions v6.5.0

@shashwatahalder01
Update workflow, fix some flaky & failed (pro) tests, add new tests (…
0d2b6aa 
…automation suite) (getdokan#2345)

* Add lint rule and fix lint issues

* Update playwright methods

* Add base page methods

* Add pre define db_port and remove grab port command

* Fix failed eu compliance test

* Fix duplicate stdout issue

* Update some sellerbadge tests and add helper methods

* Add couple of todos

* Add predefined mysqlport

* Add locatorhandler method

* Update shipping status test & schema

* Update site setup, seperate basic setp from dokan specific

* Fix db-port reference in yml

* Update product advertising test

* Update add nanoid to productnameand reset colorscheme

* Fix couple of flaky tests

* Fix flaky product QA tests and update e2e config

* Add couple of withdraw tests

* Fix assertion issue

* Remove test.only

* Update feature map

* Fix coverage issue
@shashwatahalder01 shashwatahalder01 changed the base branch from e2e-pw to develop_rk August 21, 2024 16:50
@shashwatahalder01 shashwatahalder01 merged commit f964463 into develop_rk Aug 21, 2024
1 check passed
@shashwatahalder01 shashwatahalder01 deleted the restructure branch August 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shashwatahalder01 shashwatahalder01

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashwatahalder01 @mrabbani