Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation or implementation error for degreesLat and degreesLong #74

Closed
iamthechad opened this issue Sep 14, 2020 · 2 comments · Fixed by #76
Closed

Documentation or implementation error for degreesLat and degreesLong #74

iamthechad opened this issue Sep 14, 2020 · 2 comments · Fixed by #76

Comments

@iamthechad
Copy link
Contributor

In the README, there is a section that says:

//  Convert the RADIANS to DEGREES for pretty printing (appends "N", "S", "E", "W", etc).
var longitudeStr = satellite.degreesLong(longitude),
    latitudeStr  = satellite.degreesLat(latitude);

The code for degreesLong and degreesLat, however, only returns numerical values without any of "N", "S", "E", or "W" appended. I'm not sure if this is a documentation error or an implementation error.

If it's a documentation error, the TypeScript definitions should be changed so that degreesLat and degreesLong return number instead of string.

@ezze
Copy link
Collaborator

ezze commented Sep 14, 2020

It's error in documentation. Probably, these letters are left after first serious refactoring in 2.0.0.

iamthechad pushed a commit to iamthechad/satellite-js that referenced this issue Sep 14, 2020
iamthechad added a commit to iamthechad/satellite-js that referenced this issue Sep 14, 2020
@ezze ezze closed this as completed in #76 Sep 15, 2020
@ezze
Copy link
Collaborator

ezze commented Sep 15, 2020

Fixed in 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants