Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definitions are incorrect for gstime function #73

Closed
iamthechad opened this issue Sep 14, 2020 · 3 comments · Fixed by #76
Closed

Typescript definitions are incorrect for gstime function #73

iamthechad opened this issue Sep 14, 2020 · 3 comments · Fixed by #76

Comments

@iamthechad
Copy link
Contributor

The TypeScript definition for gstime is defined as export function gstime(date: Date): GMSTime;

This is not correct, since gstime can take a Date, Julian date (number), or any valid params for jday()
@ezze
Copy link
Collaborator

ezze commented Sep 14, 2020

@iamthechad @kylegmaxwell PR is welcome! ;)

@iamthechad
Copy link
Contributor Author

I think I can put something together for this.

iamthechad pushed a commit to iamthechad/satellite-js that referenced this issue Sep 14, 2020
TypeScript and documentation fixes
b162f23 
Fixes shashwatak#73, Fixes shashwatak#74
@iamthechad iamthechad mentioned this issue Sep 14, 2020
Merged
iamthechad added a commit to iamthechad/satellite-js that referenced this issue Sep 14, 2020
@iamthechad
TypeScript and documentation fixes
2cdd045 
Fixes shashwatak#73, Fixes shashwatak#74
@ezze ezze closed this as completed in #76 Sep 15, 2020
@ezze
Copy link
Collaborator

ezze commented Sep 15, 2020

FIxed in 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeScript and documentation fixes iamthechad/satellite-js
2 participants
@iamthechad @ezze