Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swiper #12

Conversation

ashish0kumar
Copy link
Contributor

@ashish0kumar ashish0kumar commented Jun 27, 2024

fixes #9

Repository owner deleted a comment from vercel bot Jun 27, 2024
@ashish0kumar
Copy link
Contributor Author

Is there a problem ? @shawnCaza

@shawnCaza
Copy link
Owner

@ashish0kumar Thanks for adding this! I'll try to do a review within the next few days.

Copy link
Owner

@shawnCaza shawnCaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this feature going. This is a great start. Just a couple things I'd like to see cleaned up.

ui/components/show/showCards/ShowCards.tsx Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
ui/package.json Outdated Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Show resolved Hide resolved
ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Copy link

vercel bot commented Jun 30, 2024

@ashish0kumar is attempting to deploy a commit to the shawncaza's projects Team on Vercel.

A member of the Team first needs to authorize it.

ashish0kumar and others added 6 commits June 30, 2024 15:08
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
@ashish0kumar
Copy link
Contributor Author

@shawnCaza committed all the changes you suggested. 👍🏼

Copy link
Owner

@shawnCaza shawnCaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting closer. :)

One spot where we have duplication of a line, and a few spots where I unresolved a conversation that still needs attention.

Thank you!

ui/components/show/showCards/ShowCards.tsx Outdated Show resolved Hide resolved
@shawnCaza shawnCaza changed the base branch from master to Feature--Adding-option-to-use-Swiper-with-card-collections July 5, 2024 15:07
Copy link
Owner

@shawnCaza shawnCaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashish0kumar you got it!

I appreciate your help with this.

@shawnCaza shawnCaza merged commit 40e3f04 into shawnCaza:Feature--Adding-option-to-use-Swiper-with-card-collections Jul 5, 2024
1 check failed
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compodio ❌ Failed (Inspect) Jul 5, 2024 3:12pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for displaying a collection of shows with horizontal scrolling
2 participants