-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swiper #12
Add swiper #12
Conversation
Is there a problem ? @shawnCaza |
@ashish0kumar Thanks for adding this! I'll try to do a review within the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this feature going. This is a great start. Just a couple things I'd like to see cleaned up.
Co-authored-by: Shawn Caza <theshawn@gmail.com>
@ashish0kumar is attempting to deploy a commit to the shawncaza's projects Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
Co-authored-by: Shawn Caza <theshawn@gmail.com>
@shawnCaza committed all the changes you suggested. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting closer. :)
One spot where we have duplication of a line, and a few spots where I unresolved a conversation that still needs attention.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashish0kumar you got it!
I appreciate your help with this.
40e3f04
into
shawnCaza:Feature--Adding-option-to-use-Swiper-with-card-collections
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fixes #9