Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Respond.js #43

Closed
koustuvsinha opened this issue Dec 29, 2014 · 6 comments
Closed

Include Respond.js #43

koustuvsinha opened this issue Dec 29, 2014 · 6 comments

Comments

@koustuvsinha
Copy link

Respond.js is a fast & lightweight polyfill for min/max-width CSS3 Media Queries (for IE 6-8, and more), which is required for Bootstrap 2.3.0 + support in IE7 and above. Does this library already include it? If not, is there any plans to do so?

@shawnbot shawnbot self-assigned this Dec 29, 2014
@shawnbot
Copy link
Owner

Sounds interesting. I'll look into it!

@koustuvsinha
Copy link
Author

I can help, if you can explain me how to include a third party lib in aight.js source :)

@shawnbot
Copy link
Owner

Thanks! I would recommend working in the v2 branch, as that's where all of the new hotness lives. The basic steps are:

  1. Check out Respond.js as a git submodule in the lib directory
  2. Add the new respond.js path (e.g. lib/respond.js/respond.js) to the Makefile
  3. Make sure you have UglifyJS installed, e.g. npm install -g uglify-js.
  4. Run make clean all to rebuild the aight.js and aight.min.js files.
  5. Test away!

I'm considering improvements to the build process in #44 if you have any thoughts.

@koustuvsinha
Copy link
Author

I have added Respond.js and made the necessary changes. Now do I need to include tests? If so, how should I proceed?

@shawnbot
Copy link
Owner

shawnbot commented Jan 1, 2015

Happy new year, and thanks for this. Tests are weird for aight because most of them need to happen in IE8 and 9. I'm looking into automated Selenium tests, but it'll be a while before I get these set up. If Respond.js has its own tests, as both the ie8 and dom4 libraries do, then I'd say they're good enough for now. Could you file a PR to merge into v2, please?

@koustuvsinha
Copy link
Author

Happy new year to you too! Yes I am filing the PR now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants