-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Respond.js #43
Comments
Sounds interesting. I'll look into it! |
I can help, if you can explain me how to include a third party lib in aight.js source :) |
Thanks! I would recommend working in the v2 branch, as that's where all of the new hotness lives. The basic steps are:
I'm considering improvements to the build process in #44 if you have any thoughts. |
I have added Respond.js and made the necessary changes. Now do I need to include tests? If so, how should I proceed? |
Happy new year, and thanks for this. Tests are weird for aight because most of them need to happen in IE8 and 9. I'm looking into automated Selenium tests, but it'll be a while before I get these set up. If Respond.js has its own tests, as both the ie8 and dom4 libraries do, then I'd say they're good enough for now. Could you file a PR to merge into v2, please? |
Happy new year to you too! Yes I am filing the PR now! |
Respond.js is a fast & lightweight polyfill for min/max-width CSS3 Media Queries (for IE 6-8, and more), which is required for Bootstrap 2.3.0 + support in IE7 and above. Does this library already include it? If not, is there any plans to do so?
The text was updated successfully, but these errors were encountered: