Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build process friendlier #44

Closed
shawnbot opened this issue Dec 31, 2014 · 3 comments
Closed

Make the build process friendlier #44

shawnbot opened this issue Dec 31, 2014 · 3 comments

Comments

@shawnbot
Copy link
Owner

Grunt, for example, has tasks for concatenating and minifying JavaScript. The UglifyJS dependency isn't stated until you run make, which will probably confuse contributors. Alternatively, we could just add aight to npm and add uglify-js to devDependencies in the package.json.

@koustuvsinha
Copy link

While building the module I faced an issue, that is in .gitmodules file all the git links are given in git@github.com style, which gave me the error Permission denied (publickey). I had to manually change the git links to https to make it work. Is this (git@github) needed for this project exclusively? If so, contributors have to manually change .gitmodules every time they contribute?

@koustuvsinha
Copy link

As for the build process, you can also look into Gulp too, which has streaming build system consisting of tasks which is more convenient in my opinion.

@shawnbot
Copy link
Owner Author

I'm pretty happy with what we've got in v2. We've got a package.json now (but haven't registered with npm yet), so you need to install the dev dependencies first:

$ npm install

Then, you can run either of these commands to rebuild aight.js and aight.min.js:

$ npm run build
# or
$ make clean all

Running npm run watch will start watchy on the src and lib dirs and the Makefile, so that any changes to those files will trigger a rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants