-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test it with Zuul, package with npm, include html5shiv #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
added a commit
that referenced
this pull request
Jan 26, 2015
Test it with Zuul, package with npm, include html5shiv
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits introduce a zuul configuration and get everything up to snuff for automated testing with IE8 and IE9 via Sauce Labs.
Most of this work involves just getting the tests running in zuul, but some also involve forking ie8 and patching it to:
My first approach with
ie8.js
was just to monkeypatch it so that the offending lines were stripped fromaight.js
, but this didn't work for long. Once I got it working in IE9 I noticed that the Text#nodeValue shim was busted, and returning early from the shimming function was the simplest way to sidestep the issue. I also added some aliases between DOM interfaces to simplify other shims.We've also got a
package.json
for use with npm, which lists the dev dependencies necessary (and some handy script tasks) for both bundling and testing. To test, just do this:Zuul wil spit out the URL for local testing, e.g.
http://localhost:8080/__zuul
. Crack open a browser and paste that URL to run the tests interactively. I've been using VirtualBox and ievms to run the Internet Explorer tests (note that from within VirtualBox you will need to access the URL ashttp://10.0.2.2:8080/__zuul
), and as of d670123 the tests pass in both IE8 and 9.To run the automated tests, follow these instructions for telling zuul where to find your Sauce Labs credentials, then run:
$ npm test
This may take a few minutes, but you should eventually see some output that looks like this:
The
npm run watch
task is useful for rebuilding the generated files when you work on the source, andnpm run watch:test
restarts the local zuul test server whenever the generated files or tests are modified.Oh, and we're including html5shiv now too, so that's cool.