Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster matrices - value index fails when radix char is a comma #742

Closed
shawnlaffan opened this issue Aug 14, 2019 · 1 comment
Closed

Cluster matrices - value index fails when radix char is a comma #742

shawnlaffan opened this issue Aug 14, 2019 · 1 comment
Assignees
@shawnlaffan
Labels
bug locale
Milestone
Release_3

Comments

@shawnlaffan
Copy link
Owner

The value index in cluster matrices stringifies numbers using sprintf. When the locale uses a comma as the radix char this has knock on effects with the cluster analysis, as values like "0.23" are represented as "0,23", which perl later interprets as "0".

The end result is a cluster analysis with branch reversals (negative branch lengths) when there should be none.

Related to #81, #623 and #682
@shawnlaffan shawnlaffan added this to the Release_3 milestone Aug 14, 2019
@shawnlaffan shawnlaffan self-assigned this Aug 14, 2019
shawnlaffan added a commit that referenced this issue Aug 14, 2019
@shawnlaffan
Make sure we stringify matrix index using a dot as the radix char
e46ccc3 
Also throw a fatal exception when we encounter a non-numeric index val.
This second part needs further thought for backwards compatibility.

Updates #742
shawnlaffan added a commit that referenced this issue Aug 14, 2019
@shawnlaffan
Add a more informative error message
24a1215 
Updates #742
shawnlaffan added a commit that referenced this issue Aug 14, 2019
@shawnlaffan
Add locale error message to get_max_value
42ece69 
Updates #742
shawnlaffan added a commit that referenced this issue Sep 2, 2019
@shawnlaffan
Consolidate error message into a variable
8c54a51 
Updates #742
@shawnlaffan
Copy link
Owner Author

Mark as fixed.

shawnlaffan added a commit that referenced this issue Sep 3, 2019
@shawnlaffan
Correct messed up version string from 429db57
42f9628 
Updates #742
@shawnlaffan shawnlaffan mentioned this issue Jul 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
bug locale
Projects
None yet
Milestone
Release_3
Development

No branches or pull requests
1 participant
@shawnlaffan