Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #193 Removes using statement around _httpClient #194

Merged
merged 4 commits into from
Jul 21, 2017

Conversation

ctolkien
Copy link
Contributor

@ctolkien ctolkien commented Jul 21, 2017

This change:

  • Removes the using statement impacting the _httpClient - it will no longer be disposed per request
  • Adds a test for this scenario
  • Makes some changes with regards to the BaseAddress - you cannot change the BaseAddress once a request has been flighted. I have changed the public setter on this property. This is a breaking API change.
  • Had to make some changes to the test helpers with regard to the base address.

RE: Formatting, I've tried to stick with the two-spaces format which was in use... but there may be one or two bits where it's been messed up :/

Fixes #193

@ctolkien
Copy link
Contributor Author

Oh, it now makes MandrillApi implement IDisposable, which will dispose of the _httpClient which is reused.

@shawnmclean shawnmclean merged commit 532e9be into shawnmclean:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants