Introduce configurable PULL_BATCH_COUNT and DELTA_COUNT #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On tables with high volume workloads, having the ability to tune PULL_BATCH_COUNT and DELTA_COUNT is nice for faster catchup and swap. The default values are 1000 and 20 respectively. Which means, in one pass pg-osc will replay 1000 rows and if the count is <20 then it will perform the swap and replay. By introducing new cli flags (--pull-batch-count, --delta-count), these figures can be tuned further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On tables with high volume workloads,
having the ability to tune PULL_BATCH_COUNT
and DELTA_COUNT is nice for faster catchup and swap.
The default values are 1000 and 20 respectively. Which means,
in one pass pg-osc will replay 1000 rows and if the count is <20
then it will perform the swap and replay.
By introducing new cli flags (
--pull-batch-count,--delta-count),these figures can be tuned further
Fixes: #21