Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PULL_BATCH_COUNT AND DELTA_COUNT configurable by a flag #21

Closed
shayonj opened this issue Feb 5, 2022 · 0 comments · Fixed by #57
Closed

Make PULL_BATCH_COUNT AND DELTA_COUNT configurable by a flag #21

shayonj opened this issue Feb 5, 2022 · 0 comments · Fixed by #57
Labels
enhancement New feature or request p1 post-launch

Comments

@shayonj
Copy link
Owner

shayonj commented Feb 5, 2022

For tables that have a very high read/write volume, replaying 1k rows at once may not be enough for the replay to catch up to perform the swap. Making it configurable via a flag/option parameter would be nice.

https://github.com/shayonj/pg-online-schema-change/blob/1492cbeaa7c4968164a931aadab0e5860f1499ad/lib/pg_online_schema_change/orchestrate.rb#L4
@shayonj shayonj added enhancement New feature or request p3 post-launch labels Feb 5, 2022
@shayonj shayonj changed the title Make PULL_BATCH_COUNT configurable by a flag Make PULL_BATCH_COUNT AND DELTA_COUNT configurable by a flag Feb 25, 2022
@shayonj shayonj added p1 and removed p3 labels Feb 25, 2022
@shayonj shayonj mentioned this issue Feb 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request p1 post-launch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce configurable PULL_BATCH_COUNT and DELTA_COUNT shayonj/pg-osc
1 participant
@shayonj