Feature: Set weight on RPC methods #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes weight on rpc method configurable through command line argument `-m/--method`. Default weights remain the same. Example: `ethspam -m eth_blockNumber:1 -m eth_call:99` is going to send 1% of `eth_blockNumber` query and 99% of `eth_call`.
|
Another excellent addition, thank you! :) Fixes #2 |
shazow
reviewed
Mar 19, 2020
| @@ -19,7 +19,8 @@ var Version = "dev" | |||
|
|
|||
| // Options contains the flag options | |||
| type Options struct { | |||
| Web3Endpoint string `long:"rpc" description:"Ethereum JSONRPC provider, such as Infura or Cloudflare" default:"https://mainnet.infura.io/v3/af500e495f2d4e7cbcae36d0bfa66bcb"` // Versus API key on Infura | |||
| Methods map[string]int64 `short:"m" long:"method" description:"A map from json rpc methods to their weight" default:"eth_getCode:100" default:"eth_getLogs:250" default:"eth_getTransactionByHash:250" default:"eth_blockNumber:350" default:"eth_getTransactionCount:400" default:"eth_getBlockByNumber:400" default:"eth_getBalance:550" default:"eth_getTransactionReceipt:600" default:"eth_call:2000"` | |||
There was a problem hiding this comment.
It's a bit unfortunate that these defaults are buried in a single long tag line here, but not sure I have a much better solution right now.
There was a problem hiding this comment.
I agree.
Another option would be to set it in the code later on, but that prevents these from being shown with --help.
There was a problem hiding this comment.
Agree. Good enough for now, let's see if we come up with something better later. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes weight on rpc method configurable through command line
argument
-m/--method.Default weights remain the same.
Example:
ethspam -m eth_blockNumber:1 -m eth_call:99is going to send1% of
eth_blockNumberquery and 99% ofeth_call.