Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add PyOpenSSL testing. #1119

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

Lukasa
Copy link
Sponsor Contributor

@Lukasa Lukasa commented Feb 15, 2017

This slipped through code review of #1103.

@codecov-io
Copy link

Codecov Report

Merging #1119 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1119   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          21      21           
  Lines        1926    1926           
======================================
  Hits         1926    1926

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4c5f9...6c956b1. Read the comment docs.

@sethmlarson
Copy link
Member

Damn it. Sorry @Lukasa, this is what happens when I trust my tools more than use my brain to think about what's happening. I'll look over #1103 again for any other cases like this.

@Lukasa
Copy link
Sponsor Contributor Author

Lukasa commented Feb 15, 2017

Heh, no need to apologise. It's easily done, and importing just for side-effects is not generally a good practice.

@haikuginger haikuginger merged commit f52981d into urllib3:master Feb 15, 2017
@haikuginger
Copy link
Contributor

Thanks @Lukasa!

✨🍰✨

Dobatymo pushed a commit to Dobatymo/urllib3 that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants