Chunked transfer encoding on HTTP requests #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ml31415-chunked_request Thanks to @ml3141 for this work!
Lukasa
force-pushed
the
ml31415-chunked_request
branch
from
2d0ca11
to
50bec38
Compare
|
/cc @sigmavirus24 |
|
|
||
|
|
||
| class TestChunkedTransfer(SocketDummyServerTestCase): | ||
| def _start_chunked_handler(self): |
There was a problem hiding this comment.
Does this need to be private? I know start_basic_handler isn't.
There was a problem hiding this comment.
Uh, I don't think so, no. Let me fix that up.
|
👍 from me. |
| @@ -434,7 +437,8 @@ def is_same_host(self, url): | |||
|
|
|||
| def urlopen(self, method, url, body=None, headers=None, retries=None, | |||
| redirect=True, assert_same_host=True, timeout=_Default, | |||
| pool_timeout=None, release_conn=None, **response_kw): | |||
| pool_timeout=None, release_conn=None, chunked=False, | |||
There was a problem hiding this comment.
docstring for the new keyword please
|
Minor style comments, rest looks good. Ping when ready. :) 🍮 |
|
Ping! |
shazow
added a commit
that referenced
this pull request
Jan 26, 2016
Chunked transfer encoding on HTTP requests.
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Chunked transfer encoding on HTTP requests.
Dobatymo
pushed a commit
to Dobatymo/urllib3
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #775.