Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add more types and make peer library agnostic #46

Closed
shazow opened this issue Aug 8, 2023 · 3 comments
Closed

refactor: Add more types and make peer library agnostic #46

shazow opened this issue Aug 8, 2023 · 3 comments
Labels
enhancement New feature or request soon Planned, targeting a near-future release

Comments

@shazow
Copy link
Owner

shazow commented Aug 8, 2023

We could benefit from an Address type, Selector type, and maybe a Bytecode type.

Would also love to make ethers.js dependency optional (related: #36), but this means using import { keccak_256 } from "@noble/hashes/sha3" directly for hashing, and would need write our own hexlify and such. Not a huge amount of work, probably worth it to reduce barrier to adoption.

Should do this before v1.0.

@shazow shazow added enhancement New feature or request someday Good idea but not planned yet soon Planned, targeting a near-future release and removed someday Good idea but not planned yet labels Aug 8, 2023
@shazow
Copy link
Owner Author

shazow commented Aug 22, 2023

Reduced with-dependencies bundle size fom 144.73kb to 26kb, still more to do!

@shazow
Copy link
Owner Author

shazow commented Aug 22, 2023

15.48 kb with ethers 6

@shazow
Copy link
Owner Author

shazow commented Aug 22, 2023

12.29 kB with noble as peerDependencies from ethers 6.

@shazow shazow closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request soon Planned, targeting a near-future release
Projects
None yet
Development

No branches or pull requests

1 participant