Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Become provider agnostic, reduce bundle size #48

Merged
merged 14 commits into from
Aug 23, 2023
Merged

Become provider agnostic, reduce bundle size #48

merged 14 commits into from
Aug 23, 2023

Conversation

shazow
Copy link
Owner

@shazow shazow commented Aug 11, 2023 •
edited

Re #46

  • Switched from ethers 5 to ethers 6 with better tree-shaking, only using the abi parsing sub-module
  • Implement our own hex/byte conversion and keccak wrapper
  • Use noble as a peer-dependency from ethers 6
  • Overall reduced bundle size from 144 KB to 12 KB!!!❗❗❗

@shazow shazow marked this pull request as ready for review August 22, 2023 22:00
@shazow shazow changed the title WIP: Migrate keccak from ethers to noble Become provider agnostic, reduce bundle size Aug 22, 2023
@shazow shazow merged commit 034dace into main Aug 23, 2023
2 checks passed
@shazow shazow deleted the provider-agnostic branch August 23, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shazow