feat: getContract #77
Conversation
Types for EvmVersion and ContractData (return value for getContract) Implementation for Etherscan + Sourcify getContract()
There was a problem hiding this comment.
That's super thorough, looks great, thank you!
Happy to merge it as-is, or would also be cool if you'd like to add a couple of tests to https://github.com/shazow/whatsabi/blob/main/src/__tests__/loaders.test.ts just to make sure the code is exercised and doesn't get broken by accident.
I'm also happy to do it myself in a later PR if this is all you have time for. :)
|
Also apologies if it's not ready for review yet. 😅 |
|
Created it as a draft so you wouldn't feel obligated to review before tests were up. I'll write a few tests and then we can get this merged. |
|
Too hyped! lol |
|
Happy to have you merge. Looks like tests are just failing due to missing keys/providers in the github action. |
|
Yea, secrets don't get included in actions from third-party PRs. |
|
Thank you for doing this! |
Types for EvmVersion and ContractData (return value for getContract)
Implementation for Etherscan + Sourcify getContract()