Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Set same go version #10

Merged
merged 1 commit into from
Jun 13, 2022
Merged

ci: Set same go version #10

merged 1 commit into from
Jun 13, 2022

Conversation

johnmanjiro13
Copy link
Contributor

Go version of go.mod is 1.18 but go 1.17 is used in the lint workflow.
I set 1.18 to go version in the lint workflow.

@sheepla
Copy link
Owner

sheepla commented Jun 13, 2022

Oops, I overlooked Go version on workflow. Currently The workflow golang-ci-lint has failed, but since the version is different, I think there is no problem, so merge it. Thank you for letting me know!🙏

@sheepla sheepla merged commit d914aad into sheepla:master Jun 13, 2022
@sheepla
Copy link
Owner

sheepla commented Jun 13, 2022

Oh, still failing to run. sorry I will revert and fix.

sheepla added a commit that referenced this pull request Jun 13, 2022
sheepla added a commit that referenced this pull request Jun 13, 2022
sheepla added a commit that referenced this pull request Jun 13, 2022
@johnmanjiro13
Copy link
Contributor Author

johnmanjiro13 commented Jun 13, 2022

oh, I'm sorry .
My check was not enough ;(

@johnmanjiro13 johnmanjiro13 deleted the workflow-go-version branch June 13, 2022 11:32
@sheepla
Copy link
Owner

sheepla commented Jun 13, 2022

It's OK. Thanks for letting me know that the versions were different!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants