Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch Go version between go.mod and golangci-lint.yaml #16

Open
sheepla opened this issue Jun 16, 2022 · 1 comment
Open

Mismatch Go version between go.mod and golangci-lint.yaml #16

sheepla opened this issue Jun 16, 2022 · 1 comment

Comments

@sheepla
Copy link
Owner

sheepla commented Jun 16, 2022

I'm developing on Go v1.18 but golangci-lint is settings are set to a different version. So I want to fix.

#10 Thank you for notice me, johnmanjiro13!

@sheepla sheepla added the invalid This doesn't seem right label Jun 16, 2022
@sheepla
Copy link
Owner Author

sheepla commented Jun 18, 2022

golangci-lint#2649

some rules in go-critic (hugeParam, rangeValCopy, typeDefFirst, paramTypeCombine) don't work with generics and must be disabled by hand
if you are not using generics (and your dependencies) you can use the following configuration:

run:
  go: '1.17'

This code in this repository hasn't used generics yet, so it doesn't seem to matter if it stays at v1.17.

@sheepla sheepla removed the invalid This doesn't seem right label Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant