perf: wait for local ddb to be ready instead of waiting for 1s

shelfio · Aug 18, 2021 · fb6d175 · fb6d175
1 parent 6ea115d
commit fb6d175
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/setup.js b/setup.js
@@ -38,7 +38,7 @@ module.exports = async function () {
   try {
     const {TableNames: tableNames} = await Promise.race([
       dynamoDB.listTables({}),
-      new Promise(resolve => setTimeout(resolve, 1000))
+      waitForLocalhost(DEFAULT_PORT)
     ]);
     await deleteTables(dynamoDB, tableNames); // cleanup leftovers
   } catch (err) {
@@ -54,7 +54,7 @@ module.exports = async function () {
 
       global.__DYNAMODB__ = await DynamoDbLocal.launch(port, null, options);
 
-      await waitForLocalhost({port: DEFAULT_PORT, useGet: true, path: '/'});
+      await waitForLocalhost(DEFAULT_PORT);
     }
   }
 

diff --git a/wait-for-localhost.js b/wait-for-localhost.js
@@ -6,16 +6,12 @@
 
 const http = require('http');
 
-const waitForLocalhost = options => {
-  options = {...options};
-
+const waitForLocalhost = port => {
   return new Promise(resolve => {
     const retry = () => setTimeout(main, 200);
 
-    const method = options.useGet ? 'GET' : 'HEAD';
-
     const main = () => {
-      const request = http.request({method, port: options.port, path: options.path}, response => {
+      const request = http.request({method: 'GET', port, path: '/'}, response => {
         if (response.statusCode === 400) {
           return resolve();
         }