Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the user vote in manager #52

Merged
merged 2 commits into from
Jun 21, 2017
Merged

Provide the user vote in manager #52

merged 2 commits into from
Jun 21, 2017

Conversation

philippeluickx
Copy link
Contributor

Access the whole object.

@philippeluickx
Copy link
Contributor Author

Related to #48

@shellfly
Copy link
Owner

shellfly commented Jun 20, 2017

What about model.votes.get(user_id) for this feature? I think get is more intuitive.
You also need to add some tests for this method.

@philippeluickx
Copy link
Contributor Author

Will also add the method to the docs.

@philippeluickx
Copy link
Contributor Author

Changes made, please review!

@codecov-io
Copy link

Codecov Report

Merging #52 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   92.34%   92.41%   +0.07%     
==========================================
  Files           7        7              
  Lines         209      211       +2     
  Branches       14       14              
==========================================
+ Hits          193      195       +2     
  Misses         13       13              
  Partials        3        3
Impacted Files Coverage Δ
vote/managers.py 92.3% <100%> (+0.13%) ⬆️
vote/__init__.py
vote/templatetags/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab8679...363335a. Read the comment docs.

@shellfly shellfly merged commit 085dba4 into shellfly:master Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants