refactor namespace update route #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
refactor/namespace-edit
branch
3 times, most recently
from
9a92cf4
to
e7faed6
Compare
henrybarreto
reviewed
Feb 6, 2024
henrybarreto
reviewed
Feb 6, 2024
henrybarreto
reviewed
Feb 6, 2024
7 tasks
heiytor
force-pushed
the
refactor/namespace-edit
branch
5 times, most recently
from
900b5f2
to
0357a4f
Compare
Introducing a new method, `NamespaceEdit`, within the store to facilitate the updating of a namespace's attributes. This new method replaces the deprecated `NamespaceRename` and `NamespaceSetSessionRecord`. Accompanying this change is the introduction of a new struct, `NamespaceChanges`, designed to be a parameter for the `NamespaceEdit` method. This struct consolidates all possible attributes that users can modify. The use of the tag `bson:"omitempty"` helps avoid unnecessary and undesirable `if` statements by handling empty values appropriately. In the service layer, the method `EditNamespace` now calls the store method with the specified changes. This method now takes the entire request and determines its course of action (in this case, creating the `changes` struct). The validation process within the service is removed to centralize it in the router, streamlining code complexity. As part of deprecating `NamespaceRename`, we're also renaming the permission to `Namespace.Update` and `NamespaceUpdate`.
heiytor
force-pushed
the
refactor/namespace-edit
branch
from
0357a4f
to
2bf4230
Compare
In response to commit 2bf4230, we're removing the deprecated `NamespaceRename` method from the store. Now, use `NamespaceEdit` instead.
henrybarreto
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new method,
NamespaceEdit, within the store tofacilitate the updating of a namespace's attributes. This new method
replaces the deprecated
NamespaceRenameandNamespaceSetSessionRecord.Accompanying this change is the introduction of a new struct,
NamespaceChanges, designed to be a parameter for theNamespaceEditmethod. This struct consolidates all possible attributes that users can
modify. The use of the tag
bson:"omitempty"helps avoid unnecessaryand undesirable
ifstatements by handling empty values appropriately.In the service layer, the method
EditNamespacenow calls the storemethod with the specified changes. This method now takes the entire
request and determines its course of action (in this case, creating the
changesstruct). The validation process within the service is removedto centralize it in the router, streamlining code complexity.
As part of deprecating
NamespaceRename, we're also renaming thepermission to
Namespace.UpdateandNamespaceUpdate.