Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sed() could support replacement function #115

Closed
utensil opened this issue Apr 16, 2014 · 0 comments · Fixed by #117
Closed

sed() could support replacement function #115

utensil opened this issue Apr 16, 2014 · 0 comments · Fixed by #117

Comments

@utensil
Copy link
Contributor

utensil commented Apr 16, 2014

Currently shelljs.sed only supports replacement string. With just a couple of lines, it can support replacement function too. Wonder if it's ok to do so? If there's no objection, I'll create a PR for it.
utensil added a commit to utensil-contrib/shelljs that referenced this issue Apr 19, 2014
@utensil
make sed() support replacement function, fixes shelljs#115
3968dc4
@utensil utensil mentioned this issue Apr 19, 2014
Merged
arturadib added a commit that referenced this issue Apr 21, 2014
@arturadib
Merge pull request #117 from utensil/115-sed-replace-fun
7ed9cdd 
make sed() support replacement function, fixes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sed() support replacement function, fixes #115 utensil-contrib/shelljs
1 participant
@utensil