New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
silent does not always work #851
Comments
Thanks for reporting. I can repro: > exec('ls somefakefilethatdoesntexist')
ls: cannot access 'somefakefilethatdoesntexist': No such file or directory
exec: ls: cannot access 'somefakefilethatdoesntexist': No such file or directory
> exec('ls somefakefilethatdoesntexist', { silent: true })
exec: ls: cannot access 'somefakefilethatdoesntexist': No such file or directory This is a regression after v0.7.x. We should not output the lines with the |
@nfischer Hey, can I try to fix this issue? |
@uttpal sure thing. This issue fell off my radar. |
@nfischer I raised a pr can you take a look, thanks! |
when can we have the PR merged? |
@RamyRais the PR should be good, but I want to fix CI first. I'll try to work on this. |
node 8.9.1
shelljs 0.8.1
mac osx
I expect this code to not produce any output but it does.
Run it in a git repository that does not have a branch
master2
and you should see an error printedThe text was updated successfully, but these errors were encountered: