Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for #92 #93

Merged

Conversation

KINFOO
Copy link
Contributor

@KINFOO KINFOO commented Oct 3, 2017

So test case for #92

Please check one:

  • New tests created for this change
  • Tests updated for this change

This PR:

  • Fixes a bug

Globals

At first i thought RegExp from globals.js needed fixin:, I was wrong it matches @var: and @var :.
So I tried with parsing

Tokenize at rule

Running tests (new one included), I pin pointed tokenize-at-rule.js#L36.
When declaration contains a space between variable name and :,
It makes state.cssPart one character to shorter to enter word definition bloc.

Is it the way to go or am I doing it wrong?

Regards

@shellscape
Copy link
Owner

@KINFOO I'm good to merge these new tests, but please copy the text from the "Tokenize At Rule" section of your PR description to #92 and continue discussion there.

@shellscape shellscape merged commit b215771 into shellscape:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants