Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noise module #2

Merged
merged 12 commits into from
Mar 5, 2023
Merged

Noise module #2

merged 12 commits into from
Mar 5, 2023

Conversation

Goulustis
Copy link
Collaborator

implementation of GAN noise module with config files

@Goulustis
Copy link
Collaborator Author

Goulustis commented Mar 2, 2023 •
edited
Loading

Have a quick skim before merging?

@shenoynikhil
Copy link
Owner

Sure!

@shenoynikhil
Copy link
Owner

Added one comment. I think the paths related issues might crop up again. An ideal solution would be to have an .env file that stores certain paths as environment variables. Let's handle this change later/in another PR.

@shenoynikhil shenoynikhil mentioned this pull request Mar 2, 2023
Closed
@shenoynikhil shenoynikhil merged commit 2c0c019 into main Mar 5, 2023
@shenoynikhil shenoynikhil deleted the noise_module branch March 5, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goulustis @shenoynikhil