Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled grouped options get extra multiselect__option--group class #1081

Open
ewoutbeukers opened this issue Sep 12, 2019 · 5 comments
Open

Comments

@ewoutbeukers
Copy link

Fiddle to reproduce: https://jsfiddle.net/9etuLmj6/4

Upon having grouped options, where one of them is disabled and the option group-select is set to false (or not passed down as a prop), the option that should be disabled gets the extra class multiselect__option--group while it is clearly not a group.

Removing $isDisabled: true from the option or settings :group-select="true" on the multiselect will not set this class.

In the above example this can be seen because the option 'Adonis' is red or by inspecting the html.

This wouldn't really be a problem, until we want to apply custom css to option group headers.

@akki-jat
Copy link
Collaborator

akki-jat commented Oct 1, 2019

I was facing the same issue. Created MR to fix the same.
@shentao can you look into it?

@denishacquin
Copy link

Same issue here, we really need this :(

@shentao can you merge the solution above ?

@serkoffal
Copy link

@shentao I also need a solution to this problem

shentao pushed a commit that referenced this issue Mar 9, 2020
shentao added a commit that referenced this issue Mar 9, 2020
@destradafilm
Copy link

@shentao I'm wondering why multiselect__option--group also inherits multiselect__option--disabled right now they look exactly the same and that's confusing to differentiate between disabled items and group labels

@destradafilm
Copy link

also, has this been merged? Or not? confused that the case is still open but it points to a merged branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants