Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled grouped options get extra multiselect__option--group class #1125

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

akki-jat
Copy link
Collaborator

@akki-jat akki-jat commented Oct 1, 2019

for more info #1081

@shentao shentao merged commit 73b57cf into shentao:master Mar 9, 2020
@shentao
Copy link
Owner

shentao commented Mar 9, 2020

Thank you for the PR!

shentao added a commit that referenced this pull request Mar 9, 2020
@shentao
Copy link
Owner

shentao commented Mar 9, 2020

Nevermind the above "revert". Pressed on accident, the change was not reverted.

@kaidjohnson
Copy link

In the latest release (2.1.6) from npm, it appears that this PR was reverted, or else the release cut was done before March 9.

I'm still seeing this code from npm:

    groupHighlight (index, selectedGroup) {
      if (!this.groupSelect) {
        return ['multiselect__option--group', 'multiselect__option--disabled']
      }

@akki-jat
Copy link
Collaborator Author

@kaidjohnson - this is not released yet.

@aazhuravlev
Copy link

@akki-jat could you tell please when will be release to solve the problem?

@akki-jat
Copy link
Collaborator Author

@shentao - can you deploy this change in patch release?

@shentao
Copy link
Owner

shentao commented Sep 16, 2020

@akki-jat I wish I could, but the master branch is entirely broken for me. The setup requires some work... Until that’s resolved I don’t have the confidence to release anything on 2.x.

@destradafilm
Copy link

destradafilm commented Oct 9, 2020

@shentao Thanks for your work on this. Any updates on when this fix will be on the latest release?

@destradafilm
Copy link

I'm tempted to just branch off the latest release and fix this locally or just look for another library 😞

@shentao
Copy link
Owner

shentao commented Oct 19, 2020

Both options sound good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants