Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect is crashing when using groups and $isDisabled #870

Closed
sagg opened this issue Nov 5, 2018 · 6 comments
Closed

Multiselect is crashing when using groups and $isDisabled #870

sagg opened this issue Nov 5, 2018 · 6 comments
Labels

Comments

@sagg
Copy link

sagg commented Nov 5, 2018

Hi there,
i'm using grouped options and in case i provide $isDisabled: true in an option there is an error thrown in the console.

If i'm correct this should work? I only found this comment to disabled options:
#176 (comment)

Thanks a lot!

Reproduction Link

https://jsfiddle.net/sagg85/bdu2e73o/
(The shown example is a copy from the docs, i only added $isDisabled: https://vue-multiselect.js.org/#sub-option-groups)

Steps to reproduce

Setting $isDisabled when using groups.
Remove $isDisabled from the example and everything is working fine.

Expected behaviour

VueMultiselect should appear.

Actual behaviour

Error is thrown in the console.

@on4life
Copy link

on4life commented Nov 6, 2018

+1, I have the same problem

@sagg
Copy link
Author

sagg commented Nov 18, 2018

I can confirm that this solves the issue.

shentao pushed a commit that referenced this issue Nov 18, 2018
* Fixed issue - as described in issue #870

* Added test for group select with disabled values & enhanced code for wholeGroupSelected method
@nazihnemri
Copy link

nazihnemri commented Dec 12, 2018

Hi there,
i'm using grouped options and in case i provide $isDisabled: true in an option there is an error thrown in the console. but it seems not working even after the fix , please help I have the v2.1.3
Reproduction Link:
https://jsfiddle.net/m2kep3xj/

vue.js:1743 TypeError: Cannot read property 'libs' of undefined
at VueComponent.wholeGroupSelected (vue-multiselect.min.js:1)
at VueComponent.groupHighlight (vue-multiselect.min.js:1)
at vue-multiselect.min.js:1
at Proxy.renderList (vue.js:3699)
at Proxy.i (vue-multiselect.min.js:1)
at VueComponent.Vue._render (vue.js:4535)
at VueComponent.updateComponent (vue.js:2788)
at Watcher.get (vue.js:3140)
at new Watcher (vue.js:3129)
at mountComponent (vue.js:2795)

@LadyMashiro
Copy link
Contributor

@nazihnemri Any solution? I got the same error.
Reproduction link:
https://codesandbox.io/s/k09ml6wwko

@akki-jat
Copy link
Collaborator

Hi @nazihnemri and @LadyMashiro, this issue will be fixed in next release.

Note: Fix for this bug has been merged but not released yet.

@shentao
Copy link
Owner

shentao commented Mar 1, 2019

Released!

@shentao shentao closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants