Skip to content

Commit

Permalink
Fix TS issues, more correctly ship CJS and ESM (#2820)
Browse files Browse the repository at this point in the history
* Revert "🐛 Fixes import issues reported in 2785 (#2805)"

This reverts commit 5dc80bc.

* Make type module

* Split into two dist dirs

* Add attw to CI

* Explicitly set path to cjs

* Remove default

* Split output into multiple files

* Reexport svelte components

* Use babel instead of rollup-plugin-typescript

* Generate types on postbuild

* Use plugins directly

* Make eslint cjs

* Update package.json

* Fix paths

* Fix css paths

* Go back to one input file for now

* Update rollup.config.mjs

* Move shepherd to deps of cypress

* Generate svelte declarations

* Update rollup.config.mjs

* Rename declarations to cts for cjs

* Fix CJS export

* Remove index

* Fix types check command

* Ignore remaining issues

* Use api-extractor to rollup types

* Fix lint

* Fix cjs export

* Remove extra types

* Export all the things

* Update .npmignore

* Go back to multiple files

* Go back to all the old stuff

* Trying rollup-plugin-ts

* Update rollup.config.mjs

* Go back to esm and cjs folders

* Fix lint

* Add renamer

* Update rollup.config.mjs

* Remove unnecessary deps

* Update types

* Update MainPage.astro

* Manually copy declarations

* Various tweaks

---------

Co-authored-by: Chuck Carpenter <charleswcarpenter3@gmail.com>
  • Loading branch information
RobbieTheWagner and chuckcarpenter committed May 24, 2024
1 parent c18f70f commit 2873df6
Show file tree
Hide file tree
Showing 19 changed files with 1,230 additions and 165 deletions.
4 changes: 2 additions & 2 deletions docs-src/src/content/docs/guides/install.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ with:
```html
<script
type="module"
src="https://cdn.jsdelivr.net/npm/shepherd.js@10.0.1/dist/shepherd.js"
src="https://cdn.jsdelivr.net/npm/shepherd.js@12.0.4/dist/esm/shepherd.mjs"
></script>
<link
rel="stylesheet"
href="https://cdn.jsdelivr.net/npm/shepherd.js@10.0.1/dist/css/shepherd.css"
href="https://cdn.jsdelivr.net/npm/shepherd.js@12.0.4/dist/esm/css/shepherd.css"
/>
```

Expand Down
2 changes: 1 addition & 1 deletion landing/src/layouts/MainPage.astro
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,4 @@ const shepherdIncludeCode = `
</div>
</main>
<Footer />
</Base>
</Base>
Loading

0 comments on commit 2873df6

Please sign in to comment.