This repository has been archived by the owner on Apr 16, 2019. It is now read-only.
Hot reload JS files when the accompanying CSS Module file changes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New version 1.4.1 published. I was also troubled by this problem, But I don't know how to fix it. Thanks very much, your pr is great. |
|
This change will cause some problem when we don't use css module. For examples #50 #48 . So, I just add a new option for css module in the latest version 1.4.2, please use it like this https://github.com/shepherdwind/css-hot-loader/pull/51/files#diff-1072d43872977771eca42d15ddb968f2R20 now. - 'css-hot-loader',
+ 'css-hot-loader?cssModule=true', |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
module.hot.accept(undefined, cssReload);fromloader.jsRationale:
Without this change, CSS Modules don't quite work correctly. If you update a CSS Module file and change a class name, the JS file that is including it, does not get notified of the update. This is because
module.hot.accept()breaks the chain.module.hot.dispose(cssReload)is already taking care of replacing the CSS so the second call inmodule.hot.accept()is unnecessary.I've created an example to test the implementation.