Refactored code to make Sherlock a proper CLI tool and python package #152
Conversation
…ality Also changed stuff to make Sherlock usable as an API. Added ability to fail silently.
…ality Also changed stuff to make Sherlock usable as an API. Added ability to fail silently.
avinashshenoy97
force-pushed
the
master
branch
from
ca75c2f
to
2aae300
Compare
| will be saved at this folder. | ||
| --output OUTPUT, -o OUTPUT | ||
| If using single username, the output of the result | ||
| will be saved at this file. | ||
| --tor, -t Make requests over TOR; increases runtime; requires |
There was a problem hiding this comment.
I don't get why --rank, --folderoutput and --json were removed
There was a problem hiding this comment.
Slight oversight on my part... added them back :)
|
This is the 3rd pull request for doing the restructuring. I would like to get from @TheYahya on what is the way forward on these? It does not seem sensible to have multiple people doing the same thing. |
|
The checks are failing because of a connection error... it's a transient error. If the build is triggered again, it will probably go through. |
|
Thank you @avinashshenoy97, |
|
Much of the goals in this has been incorporated into #590. |
Changed code structure for to be a python package - can create setup.py and register on PyPI to make sherlock pip installable
Moved Sherlock to a class that needs to be instantiated with a username. This sherlock object can be used to check that username on some/all supported sites
Prints and CLI features moved to main.py so that all the findings are printed only when "python sherlock --site " is run.
The site arg can now be "facebook" or even just "face" and it will be matched to facebook because of how the argument is compared to the name of the websites on the supported sites list.
Moved helper functions to watson.py (hehe)
Adding a "loading /" line that shows up while Sherlock analyzes the given username's presence across all the sites.