Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: export TC related vars #37

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Makefile: export TC related vars #37

merged 1 commit into from
Dec 18, 2020

Conversation

NiLuJe
Copy link
Contributor

@NiLuJe NiLuJe commented Dec 17, 2020

Otherwise Go doesn't get the memo and builds stuff for x86_64 ;).

@shermp
Copy link
Owner

shermp commented Dec 17, 2020

Ahh, oops.

I've been building in a Docker container with GOOS and GOARCH pre-set, so I hadn't noticed.

Thanks!

@NiLuJe
Copy link
Contributor Author

NiLuJe commented Dec 17, 2020

That lead to a few puzzled moments of 'Hey, that "Finished!" popup is new' before my sleep-deprived brain realized that something stupid must have gone wrong with my build :D

@shermp
Copy link
Owner

shermp commented Dec 17, 2020

That lead to a few puzzled moments of 'Hey, that "Finished!" popup is new' before my sleep-deprived brain realized that something stupid must have gone wrong with my build :D

Yeah, well, that Finished! dialog IS new 😁. I got sick of watching my screen like a hawk for the finished toast. It's now much simpler to tell people 'don't interact with your kobo until the dialog pops up'.

@NiLuJe
Copy link
Contributor Author

NiLuJe commented Dec 17, 2020

Oh, cool, I'm not entirely out of it then ;p. Definitely a good idea, yeah ;).

@shermp shermp merged commit 3029daf into shermp:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants