Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

order for np.ones() should be a one lenght string not a bool #470

Merged
merged 1 commit into from
Jul 18, 2018
Merged

order for np.ones() should be a one lenght string not a bool #470

merged 1 commit into from
Jul 18, 2018

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Jul 10, 2018

The current usage generates a deprecation warning that is picked up as a CI error in downstream packages.

/opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/ipython:1: DeprecationWarning: Non length-one string passed in for the array ordering. Please pass in 'C', 'F', 'A', or 'K' instead
  #!/opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/python3.6

@bsipocz bsipocz mentioned this pull request Jul 12, 2018
Closed
olaurino
olaurino approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@olaurino olaurino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olaurino olaurino merged commit 668a3bc into sherpa:master Jul 18, 2018
olaurino added a commit that referenced this pull request Jul 18, 2018
@olaurino
Merge #470 (bsipocz) - order for np.ones() should be a one lenght str…
8ccc9c7 
…ing not a bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaurino olaurino olaurino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsipocz @olaurino