Clean up of error code/messages from XSPEC module. #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
Clarified error messages in Xspec extension. Also, changed the class of the exception from
RuntimeError
to more appropriate exception types, in particularLookupError
,ValueError
,KeyError
.This is a backwards-incompatible change, in that code that caught the
RuntimeError
will not catch the new error.Description
Change RuntimeError to more appropriate values, as well as some
re-wording of error messages (although it is likely that some won't
ever fire). This includes and extends a change included in PR #63 in
_sherpa_init_xspec_library().