Added property to delay masonry.destroy() #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been published to NPM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few old issues that mentioned this problem and I have found it myself when transitioning between routes in my app.
The problem is that masonry.destroy() is called immediately when components begin to destroy themselves on a page. This causes an issue during route/page transitions because all items will be aligned left in a single column (masonry is destroyed while the element is still visible during the transition).
With this addition you can set the amount of milliseconds you wish to wait for a destroy in the
destroy-delayproperty on a vue-masonry element.Fixes #77 for @nicroto and the issues users @treardon17, @kotuck, @max-schu, and @mklasinc were discussing in #48.