Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When 'show time' is false, current time should not be sent on the payload #1543

Closed
hlayisanimazuze opened this issue May 20, 2024 · 0 comments
Closed

When 'show time' is false, current time should not be sent on the payload #1543

hlayisanimazuze opened this issue May 20, 2024 · 0 comments
Assignees
@AlexStepantsov
Labels
bug Something isn't working ready for testing
Milestone
Release V0.34 (Sp...

Comments

@hlayisanimazuze
Copy link
Collaborator

hlayisanimazuze commented May 20, 2024 •
edited
Loading

If the component/configuration is set to not show time, upon creating a record, the time should not be included. Only the selected date should be sent. This behaviour also occurs when performing inline adding/editing

Steps to reproduce the behavior:

  1. Go to 'https://function-adminportal-test.shesha.dev/dynamic/TestModule/dateField-table'
  2. Open developer console
  3. Click on 'Add' button
  4. Enter all the details and click on 'Save'
  5. Check the payload
  6. Actual results: MembershipStartDate and endDate shows the current timedate while the user only selected the date

Expected behavior
If show time is set to false, when a user creates/update a record, the payload should not append the current time on the date value

Before Creating
image

After clicking save
image

Reference to release branch 33: https://function-v0-33-adminportal-test.shesha.dev/dynamic/TestModule/testAfter-table

image
@hlayisanimazuze hlayisanimazuze added the bug Something isn't working label May 20, 2024
AlexStepantsov added a commit that referenced this issue May 20, 2024
@AlexStepantsov
When 'show time' is false, current time should not be sent on the pay…
0af91ef 
…load bug #1543

Dyanamic dateField filtering sends the incorrect format expected by the endpoint bug #1542
Date not selectable during inline editing when show time property is enabled bug urgent #1541
The payload sends the exact format received from the component which differs to what the backend is expecting bug urgent #1468
Datefield formatting (DD-MM-YYYY) data doesn't match endpoint data/what has been selected bug #1166
AlexStepantsov added a commit that referenced this issue May 20, 2024
@AlexStepantsov
Merge pull request #1546 from shesha-io/alexs/1468
ec93be9 
When 'show time' is false, current time should not be sent on the payload bug #1543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexStepantsov AlexStepantsov

Labels
bug Something isn't working ready for testing
Projects
None yet
Milestone
Release V0.34 (Sprint 2)
Development

No branches or pull requests
2 participants
@AlexStepantsov @hlayisanimazuze