-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Coursera Financial Aid Application repository as a submodule" #38
Added Coursera Financial Aid Application repository as a submodule" #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZeeshanMukhtar1 thanks for this PR! I need to read to understand submodules, it's new to me. I'm pretty sure we can add this but let double check with our GitHub / open source expert @adiati98 !
Thanks for your patience, this looks like a really valuable resource. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZeeshanMukhtar1,
Thank you for your PR!
There's a couple of notes here:
- Please make two seperate PRs as you are now making changes on two different things. I believe we have separate issues for these as well. If you don't find them, please create an issue. And don't forget to link the issue number to your PRs.
- As we're only receiving PRs from our members to add themselves to our socials page, please provide you Slack handle so we can easily confirm. Please read the issue through.
- I really like the details of your PR! However, please use our PR templates for us to review your PR better. You can add the details in the "Description".
For the .gitmodules
:
We want to keep this repository as basic as possible. So we don't think we need it right now 🙂
However, your resource would be very valuable for our members!
So, you can add the link to your repository in our resources by:
- Create a new file called
scholarships.md
in theresources
folder. - Follow the format in this file to add your link to this new file.
Please let me know if you have any questions or need clarifications. :)
Hi @adiati98, i made the changes as u requested Assigned Issue
DescriptionI have created a resource to assist students in securing financial aid for online courses. This resource offers a comprehensive guide on how to apply for financial aid specifically on Coursera. It is designed to support learners on their educational journey. Type of PR
Please note that this PR falls under the "Others" category since it involves adding a new resource to the project. Changes Made:
Additional Information: I've made the recommended changes based on the feedback received, including the removal of the .gitmodules file and providing the link to my resource via "scholarships.md." This PR aligns with the project's goal of expanding the collection of resources to help the community. Checklist
Screenshots (if applicable)When I push this branch to my forked repository and create a PR, it will be set to automatically merge. is it the correct behavior |
Hey @ZeeshanMukhtar1, Thank you for the changes. If this is easier for you, let's close this PR and start fresh:
Answering your question:
It's not set to automatically merge. Only maintainers can merge PRs after they review them. Side note: |
Description
Added the "Coursera Financial Aid Application" repository as a submodule to provide valuable information on how to apply for financial aid on Coursera.
Details
I've added the external repository "Coursera-Financial-Aid-Application" as a submodule in the "resources" folder of this repository. This submodule contains a comprehensive guide on how to apply for financial aid on Coursera, which can be a valuable resource for individuals looking for financial assistance to access online courses.
This contribution aims to expand the knowledge hub by including a well-maintained and informative resource for the SheSharp community and other developers who may benefit from it.
Link
Link to Coursera Financial Aid Application Repository
Checklist
Screenshots (if applicable)
[N/A]